From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Clean up ancient test style |
Date: | 2020-12-11 16:52:12 |
Message-ID: | 1a25312b-2686-380d-3c67-7a69094a999f@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Many older tests where written in a style like
SELECT '' AS two, i.* FROM INT2_TBL ...
where the first column indicated the number of expected result rows.
This has gotten increasingly out of date, as the test data fixtures
have expanded, so a lot of these don't match anymore and are misleading.
Moreover, this style isn't really necessary, since the psql output
already shows the number of result rows. (Perhaps this was different at
some point?)
I'm proposing to clean all this up by removing all those extra columns.
The patch is very big, so I'm attaching a compressed version. You can
also see a diff oneline:
https://github.com/postgres/postgres/compare/master...petere:test-cleanup
Attachment | Content-Type | Size |
---|---|---|
0001-Clean-up-ancient-test-style.patch.gz | application/x-gzip | 76.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-12-11 17:21:17 | Rethinking plpgsql's assignment implementation |
Previous Message | Pavel Stehule | 2020-12-11 16:27:27 | Re: On login trigger: take three |