Re: SQL function which allows to distinguish a server being in point in time recovery mode and an ordinary replica

Hi!

Michael, sorry for such a long time to deliver next version of the patch
from my side.
In this version I have fixed all your propositions, hopefully correct.

There is one point that I would like to emphasize, namely
> Shouldn't STANDBY_MODE be only used in the local flag, as well as an
> ARCHIVE_RECOVERY_REQUESTED? It looks like this could push a bit more
> forward the removal of more of these booleans, with a bit more work..
I made corresponding changes, but given that these three variables
bool ArchiveRecoveryRequested;
bool InArchiveRecovery;
bool StandbyMode;
are used in other units, and (if I understand correctly) we decided to
move them in one localRecoveryFlags bitset too,
I changed their extern calls to boolean functions calls instead of
extern variables.

> The test additions are welcome.
My test additions were based on copy of StandbyModeRequested placed in
shared memory
even the startup process is done. With current implementation they seems
to be not very usefull now.

Respectfully,

Mikhail Litsarev,
Postgres Professional: https://postgrespro.com