| From: | "Kuroda, Hayato" <kuroda(dot)hayato(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Rushabh Lathia' <rushabh(dot)lathia(at)gmail(dot)com>, Michael Meskes <meskes(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> |
| Subject: | RE: ECPG regression with DECLARE STATEMENT support |
| Date: | 2019-03-11 02:03:29 |
| Message-ID: | 1F66B161998C704BABF8989B8A2AC0A31ADE84@G01JPEXMBYT05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Rushabh, Michael,
I attached a simple bug-fixing patch.
Could you review it?
An added logic is:
1. Send a close statement to a backend process regardless of the existence of a cursor.
2. If ecpg_do function returns false, raise “cursor is invalid” error.
3. Remove cursor from application.
I already checked this patch passes regression tests and Rushabh’s test code.
Best Regards,
Hayato Kuroda
Fujitsu LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| DeclareStmt_fix_close_bug.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-03-11 02:13:22 | Re: Should we add GUCs to allow partition pruning to be disabled? |
| Previous Message | David Rowley | 2019-03-11 02:00:34 | Re: Should we add GUCs to allow partition pruning to be disabled? |