Re: pgsql: Default to hidden visibility for extension libraries where possi

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: 2022-07-20 15:05:00
Message-ID: 1AB5B62F-1730-493B-B454-4A17AAB41094@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On July 20, 2022 4:20:04 PM GMT+02:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>> I suppose you're probably thinking of commit 53ef6c40f1e7; that didn't
>> expose functions directly, but through plpgsql_plugin_ptr. Maybe that
>> one does need to be made PGDLLEXPORT, since currently it isn't.
>
>Hm. Not sure if the rules are the same for global variables as
>they are for functions, but if so, yeah ...

They're the same on the export side. On windows the rules for linking to variables are stricter (they need declspec dllimport), but that doesn't matter for dlsym style stuff.

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-07-20 15:11:51 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Justin Pryzby 2022-07-20 14:52:21 [PATCH] Renumber confusing value for GUC_UNIT_BYTE

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-20 15:11:51 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Justin Pryzby 2022-07-20 14:52:21 [PATCH] Renumber confusing value for GUC_UNIT_BYTE