From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] static assertions in C++ |
Date: | 2017-12-18 20:04:57 |
Message-ID: | 19b3da77-9276-76aa-8852-f01439a7c7d6@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/11/17 17:12, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> On 12/11/17 16:45, Tom Lane wrote:
>>> (BTW, why is it that we can't fall back on the negative-width-bitfield
>>> trick for old g++?)
>
>> The complaint is
>> error: types may not be defined in 'sizeof' expressions
>
> Hmm, well, surely there's more than one way to do that; the sizeof
> is just a convenient way to wrap it in C. Wouldn't a typedef serve
> just as well?
Here is another attempt, which has the desired effect with the handful
of compilers I have available.
(With the recent changes to AllocSetContextCreate() using a static
assertion, the current state now breaks actual extensions written in C++
in some configurations, so this has become a bit of a must-fix for PG11.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
v4-0001-Add-support-for-static-assertions-in-C.patch | text/plain | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2017-12-18 20:11:32 | Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted. |
Previous Message | Peter Eisentraut | 2017-12-18 20:00:14 | Re: File name as application name in regression tests and elsewhere |