Re: Kerberos delegation support in libpq and postgres_fdw

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Peifeng Qiu <peifengq(at)vmware(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Kerberos delegation support in libpq and postgres_fdw
Date: 2021-09-01 08:57:20
Message-ID: 19afb899-318d-c61f-2de4-0e7dcbf5e0fd@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22.07.21 10:39, Peifeng Qiu wrote:
> I've slightly modified the patch to support "gssencmode" and added TAP
> tests.

For the TAP tests, please put then under src/test/kerberos/, instead of
copying the whole infrastructure to contrib/postgres_fdw/. Just make a
new file, for example t/002_postgres_fdw_proxy.pl, and put your tests there.

Also, you can put code and tests in one patch, no need to separate.

I wonder if this feature would also work in dblink. Since there is no
substantial code changes in postgres_fdw itself as part of this patch, I
would suspect yes. Can you check?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-09-01 08:58:12 Re: pg_receivewal: remove extra conn = NULL; in StreamLog
Previous Message Laurenz Albe 2021-09-01 08:56:04 Re: pgstat_send_connstats() introduces unnecessary timestamp and UDP overhead