Re: pgsql: Fix pg_type.typlen for newly-revived line type.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix pg_type.typlen for newly-revived line type.
Date: 2014-05-05 19:00:47
Message-ID: 19999.1399316447@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> Note that if the line type had been in use in the field, this would
>> break pg_upgrade'ability of databases containing line values; but
>> it seems unlikely that there are any (they'd have had to be compiled
>> with -DENABLE_LINE_TYPE).

> Should we add a test to pg_upgrade --check mode?

I doubt it's worth it. Anybody who was enabling the old code is pretty
well screwed no matter what. They can't upgrade with a plain pg_dump
either, since the I/O format is different.

What we do need, probably, is a warning about the incompatibility in the
release notes.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-05-05 19:39:28 Re: pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions.
Previous Message Tom Lane 2014-05-05 18:44:17 pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM