Re: [HACKERS] Source code format vote

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "J(dot) Roeleveld" <j(dot)roeleveld(at)softhome(dot)net>
Cc: Theo Kramer <theo(at)flame(dot)co(dot)za>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] Source code format vote
Date: 1999-12-30 17:01:52
Message-ID: 199912301701.MAA12852@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Vote is for changing tab size. Indentation will remain at 4 spaces.

[Charset iso-8859-1 unsupported, filtering to ASCII...]
> > > Current votes are:
> > >
> > > (8) 8-space tabs: Tom Lane, Peter E., Massimo, Jan, Hiroshi, Peter
> M.,
> > > Michael, Tatsuo
> > > (5) 4-space tabs: Bruce, Andreas, Vince, Vadim, D'Arcy
> > >
> > >
> > > open bracket on if () line:
> > > (7) yes: Massimo, Peter, Vince, Tom Lane, Peter M., Marc, Tatsuo
> > > (6) no: Bruce, Vadim, D'Arcy, Jan, Hiroshi, Michael M.
> > >
> > > Looks like radical change will come to our source code format for 7.0.
> > >
> > > Unless someone else speaks up, I will consider this vote closed. I will
> > > modify pgindent to reflect this format the next time it is run.
> >
> > Don't know if I qualify to vote - but if I do then I vote for 4-space tabs
> > (seeing that I often read the code - now if only two-space tabs
> > were an option...)
>
> Same here, I prefer 4-space tabs as well, looks much better on standard
> screens.
> Also I personally prefer the open bracket not to be placed in the if() line.
>
> But I'm not sure if I qualify to vote either, although I do read the code.
>
> Joost Roeleveld
>
>
> ************
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1999-12-30 17:03:26 Re: [HACKERS] 6.6 release
Previous Message Bruce Momjian 1999-12-30 17:01:29 Re: [HACKERS] Source code format vote