Re: [HACKERS] ecpg enhance patch

From: Michael Meskes <meskes(at)postgreSQL(dot)org>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] ecpg enhance patch
Date: 1999-12-27 14:52:24
Message-ID: 19991227155224.A1068@fam-meskes.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 27, 1999 at 04:49:19PM +0900, Tatsuo Ishii wrote:
> Here is a patch that would enhance the efficiency in that skip strings
> which have been already checked. The patch was made by Kazuko
> Nakagawa. Michael, can you comment on this?

The problem is that the current system allows insertions of placeholders
which are later replaced by values. After applying this patch this will no
longer work. But with some changes we might get almost the same result.

After the p = next_insert(...) p-newcopy characters are already clean. This
should be used. I just noticed that there is a ugly hack in there anyway,
namely the string length calculation via substraction of two pointers. I
wonder if this works with multibyte strings.

Michael
--
Michael Meskes | Go SF 49ers!
Th.-Heuss-Str. 61, D-41812 Erkelenz | Go Rhein Fire!
Tel.: (+49) 2431/72651 | Use Debian GNU/Linux!
Email: Michael(at)Fam-Meskes(dot)De | Use PostgreSQL!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 1999-12-27 15:35:37 Re: [HACKERS] memory dilemma
Previous Message Ansley, Michael 1999-12-27 14:23:43 RE: [HACKERS] memory dilemma