| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [HACKERS] Re: initdb.sh fixed |
| Date: | 1999-12-20 05:38:37 |
| Message-ID: | 199912200538.AAA28874@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > We currently have:
> > EffectiveUser=`id -n -u 2>/dev/null` || EffectiveUser=`whoami 2>/dev/null`
>
> OK, but is that really portable? I'd feel more comfortable with
>
> EffectiveUser=`id -n -u 2>/dev/null || whoami 2>/dev/null`
>
> because it's clearer what will happen. I wouldn't have expected an
> error inside a backquoted subcommand to determine the error result of
> the command as a whole, which is what the first example is depending on.
> In a quick test it seemed to work with the ksh I tried it on, but I
> wonder how many shells work that way...
Change applied.
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 1999-12-20 07:24:44 | Re: [HACKERS] Re: Notation for nextval() (was Re: Several small patches) |
| Previous Message | Tom Lane | 1999-12-20 05:24:17 | Re: [HACKERS] Re: initdb.sh fixed |