From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu> |
Cc: | Karel Zak - Zakkr <zakkr(at)zf(dot)jcu(dot)cz>, pgsql-hackers <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [HACKERS] psql vs. gcc |
Date: | 1999-12-17 17:43:33 |
Message-ID: | 199912171743.MAA17046@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I accidentally rejected the proper fix for this yesterday because there
was no description about what it was supposed to fix. Let me see if I
can get it now.
> > If I compile current source, gcc (2.95.2) return interesting error for
> > pgsql/describe.c.
> > The gcc return error for next lines:
> > strcpy(buf,
> > "SELECT pg_database.datname as \"Database\",\n"
> > " pg_user.usename as \"Owner\""
> > #ifdef MULTIBYTE
> > ",\n pg_database.encoding as \"Encoding\""
> > #endif
> > );
>
> I'm sure we would accept a patch that changed this into a
>
> strcpy()
> #ifdef MULTIBYTE
> strcat()
> #endif
>
> sequence rather than this monolithic line.
>
> - Thomas
>
> --
> Thomas Lockhart lockhart(at)alumni(dot)caltech(dot)edu
> South Pasadena, California
>
> ************
>
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1999-12-17 17:53:45 | Re: [HACKERS] bug in Debian's pgaccess package |
Previous Message | Jan Wieck | 1999-12-17 17:42:36 | Re: [HACKERS] Re: Notation for nextval() (was Re: Several small patches) |