Re: [HACKERS] Operator definitions

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: Adriaan Joubert <a(dot)joubert(at)albourne(dot)com>, Lamar Owen <lamar(dot)owen(at)wgcr(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgresql <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] Operator definitions
Date: 1999-09-23 15:39:18
Message-ID: 199909231539.LAA17066@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > > It looks to me like '^' and '|' have been left out of the alternatives
> > > for MathOp in src/backend/parser/gram.y. It could be they were
> > > deliberately omitted, but I bet it's just an oversight.
> > OK, here is a patch to allow both ^ and | as operators, both in operator
> > definitions and expressions. It seems to work for me. Unfortunately the
> > regression tests do not tell me an awful lot, as several of them fail on
> > the Alpha anyway. As I don;t really know what I'm doing, I'd appreciate
> > it if somebody else could check the patch out and let me know whether it
> > is ok.
>
> It's fine as far as it goes, but istm that there are other cases
> missing from gram.y also :(
>
> Bruce, how did this stuff get into the stable release? Looks like we
> are going to need a v6.5.3 Real Soon Now. And packagers, we should
> plan on having a patch for v6.5.2. I'll try coming up with one in the
> next couple of days; I've tested on my own gram.y but it has too many
> other changes to be used as-is.

I have no idea how this got in. Looking at the cvs logs, I don't see
anything since 6.5 that would cause this to break in 6.5.2. Even
looking at an actual diff against 6.5.1, I don't see anything.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message InfraRED/Veres Tibor 1999-09-23 15:45:01 Re: [HACKERS] [GENERAL] when are indexes used?
Previous Message Bruce Momjian 1999-09-23 15:31:04 Re: [HACKERS] Progress report: buffer refcount bugs and SQL functions