From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers(at)thewrittenword(dot)com |
Cc: | pgsql-hackers(at)postgreSQL(dot)org, pgsql-admin(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5 |
Date: | 1999-07-10 14:36:25 |
Message-ID: | 199907101436.KAA18000@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Sat, Jul 10, 1999 at 02:45:47AM -0400, Bruce Momjian wrote:
> > I didn't understand this the first time you sent it either.
> >
> > Send me a patch to review, please.
>
> --- src/pl/tcl/mkMakefile.tcldefs.sh.in.orig Fri Jul 9 08:29:09 1999
> +++ src/pl/tcl/mkMakefile.tcldefs.sh.in Fri Jul 9 08:29:49 1999
> @@ -8,9 +8,6 @@
>
> cat @TCL_CONFIG_SH@ |
> egrep '^TCL_|^TK_' |
> - while read inp
> - do
> - eval eval echo $inp
> - done >Makefile.tcldefs
> + sed -e "s/^\([^=]*\)='\(.*\)'$/\1=\2/" >Makefile.tcldefs
>
I understand what your patch does, and it looks OK, but any idea why the
'eval eval' was there, and is it safe to skip it? I can apply this to
6.6.
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Vince Vielhaber | 1999-07-10 14:59:08 | Wdb-p95 |
Previous Message | Chris Bitmead | 1999-07-10 13:50:49 | Unique index problem |