Re: [SQL] RewriteDefine.c : Rule size

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Rowan <jmr(at)computing(dot)com>, Jan Wieck <jwieck(at)debis(dot)com>, Olivier Ertz <ertz(at)illite(dot)u-strasbg(dot)fr>, pgsql-sql(at)postgreSQL(dot)org
Subject: Re: [SQL] RewriteDefine.c : Rule size
Date: 1999-07-09 16:56:57
Message-ID: 199907091656.MAA01689@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-sql

> There is a poorly-documented restriction that BLCKSZ can't exceed 32K
> (IIRC, this is because block offsets are stored in signed shorts somewhere).
> Probably would be a good idea to mention this in the comments in
> config.h.in.
>
> For the long run it would be nice to remove the restriction. I have no
> idea whether that would be easy or hard. Ideally we could do something
> like
>
> #if BLCKSZ > 32767
> typedef int BlockOffset;
> #else
> typedef short BlockOffset;
> #endif
>
> but finding all the places that need to use the typedef might be a pain.

Added comment to config.h.in, and TODO item:

* Allow BLCKSZ <= 64k, not <= 32k

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-sql by date

  From Date Subject
Next Message Eid, Bilal 1999-07-09 17:27:18 RE: [SQL] offtopic: odbc C frontend for linux?
Previous Message Bruce Momjian 1999-07-09 16:54:38 Re: [SQL] RewriteDefine.c : Rule size