From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu> |
Cc: | PostgreSQL-development <hackers(at)postgreSQL(dot)org> |
Subject: | NULL = col |
Date: | 1999-05-10 19:01:30 |
Message-ID: | 199905101901.PAA09049@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> > > I would like for you to also consider adding the following to gram.y for
> > > version 6.5:
> > > | NULL_P '=' a_expr
> > > { $$ = makeA_Expr(ISNULL, NULL, $3, NULL); }
> > > I know there was some discussion about this earlier including comments
> > > against this. Access 97 is now generating the following statement and
> > > error...
>
> I'm not certain that this patch should survive. There are at least two
> other places in the parser which should be modified for symmetry (the
> "b_expr" and the default expressions) and I recall that these lead to
> more shift/reduce conflicts. Remember that shift/reduce conflicts
> indicate that some portion of the parser logic can *never* be reached,
> which means that some feature (perhaps the new one, or perhaps an
> existing one) is disabled.
Yes, that is true. There are several cases where we check just for =
NULL and not NULL = in the internals, not the grammar.
>
> There is currently a single shift/reduce conflict in gram.y, and I'm
> suprised to find that it is *not* due to the "NULL_P '=' a_expr" line.
Yep. I got that working with precidence for NULL, I think.
> I'm planning on touching gram.y to hunt down the shift/reduce conflict
> (from previous work I think it in Stefan's "parens around selects"
> mods), and I'll look at the NULL_P issue again also.
>
> I'll reiterate something which everyone probably knows: "where NULL =
> expr" is *not* standard SQL92, and any company selling products which
> implement this rather than the standard "where expr is NULL" should
> make your "don't buy" list, rather than your "only buy" list, which is
> what they are trying to force you to do :(
Yes, but some of the tools output that, and I think that was the
complaint. I can go either way on this.
>
> - Tom
Any chance of making your signature Thomas, to not confuse it with Tom
Lane?
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1999-05-10 19:07:51 | subselects |
Previous Message | Jan Wieck | 1999-05-10 18:43:27 | Re: [HACKERS] numeric & decimal |