Re: [HACKERS] Minor pg_dump buglet

Sure, can you send us a patch:

> Also, in getTables() in pg_dump.c there are at least a couple of these:
> if (!res ||
> PQresultStatus(res) != PGRES_COMMAND_OK)
> {
> fprintf(stderr, "BEGIN command failed\n");
> exit_nicely(g_conn);
> }
>
> Shouldn't this be more like
> if (!res ||
> PQresultStatus(res) != PGRES_COMMAND_OK)
> {
> fprintf(stderr, "BEGIN command failed(%s)\n", PGresultErrorMessage(res));
> exit_nicely(g_conn);
> }
> or
> if (!res)
> {
> fprintf(stderr, "BEGIN command failed\n");
> exit_nicely(g_conn);
> } else if(PGresultStatus(res) != PGRES_COMMAND_OK) {
> fprintf(stderr, "BEGIN command failed. ERROR: %s\n", PGresultErrorMessage(res));
> exit_nicely(g_conn);
> }
>
> Thanks,
> Ole Gjerde
>
>
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026