From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>, pgsql-hackers(at)hub(dot)org |
Subject: | Re: [HACKERS] It would be nice if this could be fixed... |
Date: | 1999-05-07 03:05:10 |
Message-ID: | 199905070305.XAA09049@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> I think it'd be a good idea to try to centralize this knowledge so that
> there are fewer places to change to add a new node type. For example,
> a routine that wants to examine all the Var nodes in a tree should be
> able to look something like this:
>
> if (IsA(node, Var))
> {
> process var node;
> }
> else
> standard_tree_walker(node, myself, ...);
>
> rather than having another copy of a bunch of error-prone boilerplate.
That is an interesting idea. The current code clearly needs cleanup and
is error-prone.
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Chris Bitmead | 1999-05-07 03:36:59 | pg_dump problem? |
Previous Message | Tom Lane | 1999-05-07 02:36:29 | Re: [HACKERS] Hashjoin status report |