Re: [HACKERS] snprintf() instead of sprintf() ?

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Inoue(at)tpf(dot)co(dot)jp (Hiroshi Inoue)
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] snprintf() instead of sprintf() ?
Date: 1999-03-16 05:01:36
Message-ID: 199903160501.AAA02171@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I have gone through the code, and added pstrdup() to cases where
snprintf was uses with the same string on input and output. Should fix
these problems.

---------------------------------------------------------------------------

Hello all,

CREATE USER/ALTER USER doesn't work well for
99/02/23 snapshot;

=> create user user1;
ERROR: Bad abstime external representation ''

I didn't understand the reason.

=> alter user fred createuser;
ERROR: parser: parse error at or near "where"

I found it's because of the use snprintf() instead
of sprintf(). Different from sprintf(),snprintf()
clears its target first.
AlterUser() function uses the statement such as

snprintf(sql, "....", sql, ...)

In this case,the content of sql which is also a
source of snprintf is cleared before execution.

Thanks.

Hiroshi Inoue
Inoue(at)tpf(dot)co(dot)jp

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ryan Bradetich 1999-03-16 07:34:33 Re: [HACKERS] Sequences....
Previous Message Bruce Momjian 1999-03-16 04:57:04 Re: [HACKERS] Re: [GENERAL] Bug with sequences in 6.4.2