Re: [HACKERS] [CURRENT] contrib/array_iterator patch

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: t-ishii(at)sra(dot)co(dot)jp (Tatsuo Ishii)
Cc: pgsql-patches(at)postgreSQL(dot)org, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] [CURRENT] contrib/array_iterator patch
Date: 1999-03-16 03:10:09
Message-ID: 199903160310.WAA26127@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Applied.

> contrib/array_iterator/array_iterator.c won't compile.
> Included patches should fix the problem.
> --
> Tatsuo Ishii
>
> *** pgsql/contrib/array/array_iterator.c~ Fri Jan 22 07:40:16 1999
> --- pgsql/contrib/array/array_iterator.c Tue Mar 16 11:31:40 1999
> ***************
> *** 28,37 ****
>
> #include "array_iterator.h"
>
> array_iterator(Oid elemtype, Oid proc, int and, ArrayType *array, Datum value)
> {
> HeapTuple typ_tuple;
> ! TypeTupleForm typ_struct;
> bool typbyval;
> int typlen;
> func_ptr proc_fn;
> --- 28,38 ----
>
> #include "array_iterator.h"
>
> + static int32
> array_iterator(Oid elemtype, Oid proc, int and, ArrayType *array, Datum value)
> {
> HeapTuple typ_tuple;
> ! Form_pg_type typ_struct;
> bool typbyval;
> int typlen;
> func_ptr proc_fn;
> ***************
> *** 43,48 ****
> --- 44,50 ----
> *dim;
> char *p;
> FmgrInfo finf; /*Tobias Gabele Jan 18 1999*/
> +
>
> /* Sanity checks */
> if ((array == (ArrayType *) NULL)
> ***************
> *** 67,73 ****
> elog(ERROR, "array_iterator: cache lookup failed for type %d", elemtype);
> return 0;
> }
> ! typ_struct = (TypeTupleForm) GETSTRUCT(typ_tuple);
> typlen = typ_struct->typlen;
> typbyval = typ_struct->typbyval;
>
> --- 69,75 ----
> elog(ERROR, "array_iterator: cache lookup failed for type %d", elemtype);
> return 0;
> }
> ! typ_struct = (Form_pg_type) GETSTRUCT(typ_tuple);
> typlen = typ_struct->typlen;
> typbyval = typ_struct->typbyval;
>
> [srapc451.sra.co.jp]t-ishii{123}
>
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 1999-03-16 03:15:49 Re: [HACKERS] Developers Globe (FINAL)
Previous Message Bruce Momjian 1999-03-16 03:08:12 Re: [HACKERS] "CANNOT EXTEND" -