From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | phd2(at)earthling(dot)net |
Cc: | darcy(at)druid(dot)net, pgsql-hackers(at)postgreSQL(dot)org, angelos(at)awesome(dot)incredible(dot)com |
Subject: | Re: [HACKERS] Re: your mail |
Date: | 1999-03-15 15:10:11 |
Message-ID: | 199903151510.KAA13342@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Ah, here is an even clearer statement on unsigned.
> On Thu, 11 Feb 1999, D'Arcy J.M. Cain wrote:
> > > should use: signed or unsigned chars, anyone has an idea?
> >
> > In all my own code, I always set the compiler option to make char an
> > unsigned type. For portability I like to know that the behaviour
> > won't change as long as I carry over my compiler options. I like
> > that way better than casting since I don't get conflict warnings
> > for sending unsigned (or signed) char to library functions. Remember,
> > char, signed char and unsigned char are 3 distinct types even though
> > char has to behave exactly like one of the other two. Setting it up on
> > the compiler command line gets around that.
> >
> > As for signed vs. unsigned, I don't think it matters that much. I chose
> > unsigned since I never do signed arithmetic on char and if I ever did I
> > would like to have the extra keywork to draw attention to it.
>
> That is what I think of, and what I usually use - tweak compiler options
> to unsigned char.
> So, my conclusion - reject the patch and teach people to change compiler
> options.
>
> Oleg.
> ----
> Oleg Broytmann http://members.xoom.com/phd2/ phd2(at)earthling(dot)net
> Programmers don't die, they just GOSUB without RETURN.
>
>
>
>
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 1999-03-15 15:18:22 | Re: [HACKERS] VACUUM ANALYZE problem on linux |
Previous Message | Bruce Momjian | 1999-03-15 15:05:53 | Re: [HACKERS] Re: your mail |