Re: [HACKERS] equal: don't know whether nodes of type 600 are equal

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us (Tom Lane)
Cc: jwieck(at)debis(dot)com, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] equal: don't know whether nodes of type 600 are equal
Date: 1999-02-07 20:36:34
Message-ID: 199902072036.PAA15867@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> This error is coming from inside the planner (specifically union_planner).
> Obviously there's *something* different about the context in which the
> planner is invoked for EXPLAIN.
>
> It looks to me like the problem is that some rewrite code got placed in
> pg_parse_and_plan() in postgres.c --- there is some UNION-handling stuff
> going on *after* the call to QueryRewrite(), and evidently that stuff
> is not duplicated in the EXPLAIN case. Probably the right fix is to
> move all that logic inside QueryRewrite() --- but I don't want to touch
> it without confirmation from someone who knows the parser/planner
> better.

I have been meaning to move the UNION stuff into the rewrite system
where it belongs, but haven't had time to do it. In tcop/postgres.c,
you will see me moving through the union nodes. That should be done at
the top of the rewrite system. At the time, the rewrite system was so
confusing to me, I did not attempt it. I believe that will fix the
problem. Let me know if you need me to do it.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 1999-02-07 20:45:03 Re: [HACKERS] v6.4.3 ?
Previous Message Tom Lane 1999-02-07 20:35:34 Re: [HACKERS] Problems building some libraries in 6.4.2