From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | goran(at)kirra(dot)net (Goran Thyni) |
Cc: | hackers(at)postgreSQL(dot)org |
Subject: | Re: New patch (was: tough bug) |
Date: | 1999-02-02 19:20:56 |
Message-ID: | 199902021920.OAA07138@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Applied.
[Charset iso-8859-1 unsupported, filtering to ASCII...]
>
> OK I found it,
> I search in the planner for the '\xFF' appending.
> Finally I found in MakeIndexable() in gram.y
>
> Attach a patch which removes the "<=" test in USE_LOCALE,
> might make some queries a bit slower for us "locale-heads",
> BUT correct result is more important.
>
> regards,
> --
> -----------------
> G_ran Thyni
> This is Penguin Country. On a quiet night you can hear Windows NT
> reboot!
> diff -c pgsql/src/backend/parser/gram.y.orig pgsql/src/backend/parser/gram.y
> *** pgsql/src/backend/parser/gram.y.orig Tue Jan 26 07:02:32 1999
> --- pgsql/src/backend/parser/gram.y Mon Feb 1 21:16:56 1999
> ***************
> *** 5249,5259 ****
> --- 5249,5265 ----
> least->val.val.str = match_least;
> most->val.type = T_String;
> most->val.val.str = match_most;
> + #ifdef USE_LOCALE
> + result = makeA_Expr(AND, NULL,
> + makeA_Expr(OP, "~", lexpr, rexpr),
> + makeA_Expr(OP, ">=", lexpr, (Node *)least));
> + #else
> result = makeA_Expr(AND, NULL,
> makeA_Expr(OP, "~", lexpr, rexpr),
> makeA_Expr(AND, NULL,
> makeA_Expr(OP, ">=", lexpr, (Node *)least),
> makeA_Expr(OP, "<=", lexpr, (Node *)most)));
> + #endif
> }
> }
> }
> ***************
> *** 5296,5306 ****
> --- 5302,5318 ----
> least->val.val.str = match_least;
> most->val.type = T_String;
> most->val.val.str = match_most;
> + #ifdef USE_LOCALE
> + result = makeA_Expr(AND, NULL,
> + makeA_Expr(OP, "~~", lexpr, rexpr),
> + makeA_Expr(OP, ">=", lexpr, (Node *)least));
> + #else
> result = makeA_Expr(AND, NULL,
> makeA_Expr(OP, "~~", lexpr, rexpr),
> makeA_Expr(AND, NULL,
> makeA_Expr(OP, ">=", lexpr, (Node *)least),
> makeA_Expr(OP, "<=", lexpr, (Node *)most)));
> + #endif
> }
> }
> }
>
>
>
>
>
>
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Hannu Krosing | 1999-02-02 19:22:13 | 6.5 beta and ORDER BY patch |
Previous Message | Bruce Momjian | 1999-02-02 19:20:02 | Re: [HACKERS] Patch (was: tough locale bug) |