Re: [HACKERS] include/port directory?

From: Brook Milligan <brook(at)trillium(dot)NMSU(dot)Edu>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] include/port directory?
Date: 1998-11-10 19:04:46
Message-ID: 199811101904.MAA07844@trillium.nmsu.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> @if [ ! -d $(HEADERDIR)/port/$(PORTNAME) ]; \
> then mkdir $(HEADERDIR)/port/$(PORTNAME); fi

Some of the ports put stuff into that directory, some don't.
(HPUX does, as you would've noticed if you looked about seven lines
above this line.)

Oops. I missed that.

> What is the point if creating it in the first place? Should stuff be
> put in there or should the directory disappear?

I'd say leave it alone. Even if we don't have a lot of use for it
at the moment, what's it hurt?

It doesn't really hurt anything, except for two things. It causes a
bit of confusion and it presents a small problem when trying to
construct postgresql packages that contain the entire distribution
(empty directories need special casing and when figuring out if that
special casing is necessary the confusion arises; or at least it did
for me when I was doing exactly that). May I suggest the following
patch that makes it clear exactly what is going on (when one looks at
the installed code) and makes construction of packages
straightforward.

Cheers,
Brook

===========================================================================
--- interfaces/libpq/Makefile.in.orig Sun Oct 18 18:00:43 1998
+++ interfaces/libpq/Makefile.in Tue Nov 10 11:18:17 1998
@@ -107,6 +107,7 @@
$(HEADERDIR)/commands/trigger.h
$(INSTALL) $(INSTLOPTS) libpq-fe.h $(HEADERDIR)/libpq-fe.h
$(INSTALL) $(INSTLOPTS) libpq-int.h $(HEADERDIR)/libpq-int.h
+ $(INSTALL) $(INSTLOPTS) .keep_me $(HEADERDIR)/port/$(PORTNAME)/.keep_me
ifeq ($(PORTNAME), hpux)
$(INSTALL) $(INSTLOPTS) $(SRCDIR)/backend/port/hpux/fixade.h \
$(HEADERDIR)/port/hpux/fixade.h
===========================================================================
--- interfaces/libpq/.keep_me.orig Tue Nov 10 11:20:28 1998
+++ interfaces/libpq/.keep_me Tue Nov 10 11:20:14 1998
@@ -0,0 +1,2 @@
+This normally empty directory needs to be kept in the distribution for
+port-specific header files.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fuad Abdallah 1998-11-10 20:25:42 6.4 error with oid type
Previous Message Tom Lane 1998-11-10 16:47:43 Re: [HACKERS] include/port directory?