Re: [HACKERS] DestroyDB Patch *** Update

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: francois(at)nexus-is(dot)qc(dot)ca (Francois Machabee)
Cc: lockhart(at)alumni(dot)caltech(dot)edu, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] DestroyDB Patch *** Update
Date: 1998-10-27 03:25:18
Message-ID: 199810270325.WAA02385@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

[Charset iso-8859-1 unsupported, filtering to ASCII...]
> Hi there,
>
> Here is the proper diff -c patch file for the previously mentionned patch :
>
> *** junkfilter_patch.txt Fri Oct 23 10:26:14 1998
> --- patch-fm Thu Oct 22 09:17:34 1998
> ***************
> *** 29,35 ****
> JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList);
> estate->es_junkFilter = j;
> +
> ! + tupType = j->jf_cleanTupType; /* Added by daveh(at)insightdist(dot)com 5/20/98 */
> }
> else
> estate->es_junkFilter = NULL;
> --- 29,35 ----
> JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList);
> estate->es_junkFilter = j;
> +
> ! + if (operation != CMD_DELETE) {tupType = j->jf_cleanTupType;} /* Added by daveh(at)insightdist(dot)com 5/20/98 modified by Francois Machabee 10/21/1998 */
> }
> else
> estate->es_junkFilter = NULL;

I can't apply this one either. First, it is not a patch, but a patch on
a patch. The line that starts "! +" says that. Second, am I supposed
to guess what file this is supposed to be applied to? I can't figure it
out, but it could be execMain.c. And third, it does not match any code
in the executor in the 6.4 beta tree. Please send a patch that can
apply against the 6.4 beta on ftp.postgresql.org.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Douglas W Babst 1998-10-27 06:10:39 Re: [HACKERS] Last call?
Previous Message The Hermit Hacker 1998-10-27 03:10:48 BETA3...