Re: [HACKERS] How to...?

From: Andrew Martin <martin(at)biochemistry(dot)ucl(dot)ac(dot)uk>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, scrappy(at)hub(dot)org
Subject: Re: [HACKERS] How to...?
Date: 1998-03-09 17:39:20
Message-ID: 199803091739.RAA22436@bsmir06.biochem.ucl.ac.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > I do think it would be a good idea if the pg_dumpall from the new release
> > looked for these now-reserved column names and warned the user. You could
> > then at least know where problems will occur. In upgrades from d/b versions
> > which support ALTER TABLE xxx RENAME COLUMN yyy TO zzz, you would actually
> > be able to do something about it before re-dumping...
>
> pg_dumpall is just a shell script. You would have to do it in pg_dump.
> I hesistate to meddle with that code unless I have good reason for it.
Having psql core dump seems like a pretty good reason to me :-)

> We could have a separate function that scans pg_attribute looking for
> bad column names.
Whatever... This could be run as the first stage of pg_dumpall to say
"Hey these column names are no longer allowed..."

> Bruce Momjian | 830 Blythe Avenue

Andrew

----------------------------------------------------------------------------
Dr. Andrew C.R. Martin University College London
EMAIL: (Work) martin(at)biochem(dot)ucl(dot)ac(dot)uk (Home) andrew(at)stagleys(dot)demon(dot)co(dot)uk
URL: http://www.biochem.ucl.ac.uk/~martin
Tel: (Work) +44(0)171 419 3890 (Home) +44(0)1372 275775

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 1998-03-09 18:02:26 Re: [QUESTIONS] DANGER WILL ROBINSON!
Previous Message Zeugswetter Andreas 1998-03-09 17:19:16 Re: [HACKERS] newoid in invapi.c