compilation on sparc_solaris

From: Shiby Thomas <sthomas(at)cise(dot)ufl(dot)edu>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: pgsql-hackers(at)postgreSQL(dot)org, pgsql-ports(at)postgreSQL(dot)org
Subject: compilation on sparc_solaris
Date: 1998-02-02 19:06:13
Message-ID: 199802021906.OAA00434@cise.ufl.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

It looks like the compilation problem on sparc_solaris is due to some
inconsistencies in the Makefiles. The -D$(PORTNAME) is not passed in
CFLAGS. I made the foll. changes and it compiled fine.

I am attaching the diffs that I made to the Makefiles. Please let me know
if they are correct and if so fix them in the main source tree.
src/Makefile.global.in :
47,53d46
< # Note that portname is defined here to be UNDEFINED to remind you
< # to change it in Makefile.custom.
< #
< # make sure that you have no whitespaces after the PORTNAME setting
< # or the makefiles can get confused
< PORTNAME= @PORTNAME@
<
285,287d279
<
< # Globally pass PORTNAME
< CFLAGS+= -D$(PORTNAME)

src/backend/Makefile:
71c71
< $(MAKE) -C $(subst .dir,,$@) all PORTNAME=$(PORTNAME)
---
> $(MAKE) -C $(subst .dir,,$@) all
107c107
< for i in $(DIRS); do $(MAKE) -C $$i clean PORTNAME=$(PORTNAME); done
---
> for i in $(DIRS); do $(MAKE) -C $$i clean; done
110c110
< for i in $(DIRS); do $(MAKE) -C $$i $@ PORTNAME=$(PORTNAME); done
---
> for i in $(DIRS); do $(MAKE) -C $$i $@; done
171c171
< ./makeID $(PORTNAME)
---
> ./makeID

src/backend/port/Makefile: (Here I think the fix should be in Makefile.in; I
just edited the Makefile to try if it fixes problem)
28c28
< OBJS = $(PORTNAME)/SUBSYS.o dynloader.o inet_aton.o
---
> OBJS = dynloader.o inet_aton.o
31c31
< all: submake SUBSYS.o
---
> all: SUBSYS.o
37,39d36
<
< submake:
< $(MAKE) -C $(PORTNAME) SUBSYS.o

--shiby

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message teunis 1998-02-02 19:23:16 Re: [HACKERS] (: JDBC+(Sun ~3:pm MST) CVS :) -also question about regression tests
Previous Message ocie 1998-02-02 18:52:10 Re: [HACKERS] subquery syntax broken