Re: auto_explain causes regression failures

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: auto_explain causes regression failures
Date: 2010-02-17 06:21:40
Message-ID: 19961.1266387700@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> Thank you for the bug report. Auto_explan tries to explain the query
> even if it is failed, but schema objects that are created in the same
> transaction might not be available. "cache lookup failed" erros can be
> avoided if auto_explain skips explaining queries in aborted transactions.

I don't think this is auto_explain's fault. ExecutorEnd() shouldn't
be getting run in an aborted xact --- there are too many other things
that are likely to fall over. See my response to Andrew.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Scott Bailey 2010-02-17 06:23:37 Re: XQuery support
Previous Message Tom Lane 2010-02-17 06:16:28 Re: auto_explain causes regression failures