| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Andy Colson <andy(at)squeakycode(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: savepoint commit performance |
| Date: | 2011-09-06 20:12:37 |
| Message-ID: | 19938.1315339957@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Sep 5, 2011 at 1:56 PM, Andy Colson <andy(at)squeakycode(dot)net> wrote:
>> This patch:
>>
>> https://commitfest.postgresql.org/action/patch_view?id=605
>>
>> Seems to have been after thoughts, and back burner stuff, and forgotten
>> about...
>>
>> Has it already been commit?
>>
>> http://archives.postgresql.org/pgsql-committers/2011-07/msg00206.php
>>
>> Oh, wait, nevermind, it was revoked and reworked:
>>
>> http://archives.postgresql.org/pgsql-hackers/2011-07/msg01041.php
>>
>> but that was posted Jul 19, 2011. And the Patch linked from commitfest is
>> Jun 6, 2011. So is that an old patch? Or a new patch?
>>
>> I'm confused.
> As far as I can see, Simon stated that he would revert it but never did so.
> Perhaps we should go do that...
The patch is definitely still in the tree. Given the dangling-pointer
concerns raised by Heikki, I think we had better revert it before
shipping 9.1. Also, the entry in the September commitfest can be marked
"returned with feedback", since it clearly predates the discussion on
-hackers.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-09-06 20:14:46 | Re: regular logging of checkpoint progress |
| Previous Message | Robert Haas | 2011-09-06 20:07:55 | Re: Large C files |