| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Gunther <raj(at)gusw(dot)net>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-performance(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Out of Memory errors are frustrating as heck! |
| Date: | 2019-04-22 17:57:34 |
| Message-ID: | 19881.1555955854@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-performance |
Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> Is there a reason to not just elog the HJDEBUG stuff?
Yes --- it'd be expensive (a "no op" elog is far from free) and
useless to ~ 99.999% of users.
Almost all the conditionally-compiled debug support in the PG executor
is legacy leftovers from Berkeley days. If it were useful more often
than once in a blue moon, we probably would have made it more easily
reachable long ago. I'm a bit surprised we haven't just ripped it
out, TBH. When I find myself needing extra debug output, it's almost
never the case that any of that old code does what I need.
There might be a case for changing it all to print to stderr not
stdout, so that it plays more nicely with elog/ereport output
when you do have it turned on, though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gunther | 2019-04-23 20:37:50 | Re: Out of Memory errors are frustrating as heck! |
| Previous Message | Jeff Janes | 2019-04-22 17:15:10 | Re: Out of Memory errors are frustrating as heck! |