From: | Antonin Houska <ah(at)cybertec(dot)at> |
---|---|
To: | Richard Guo <riguo(at)pivotal(dot)io> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] WIP: Aggregation push-down |
Date: | 2019-07-17 14:39:52 |
Message-ID: | 19857.1563374392@localhost |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Richard Guo <riguo(at)pivotal(dot)io> wrote:
> Another core dump for query below:
>
> select sum(t1.s1) from t1, t2, t3, t4 where t1.j1 = t2.j2 group by t1.g1, t2.g2;
>
> This is due to a small mistake:
>
> diff --git a/src/backend/optimizer/util/relnode.c b/src/backend/optimizer/util/relnode.c
> index 10becc0..9c2deed 100644
> --- a/src/backend/optimizer/util/relnode.c
> +++ b/src/backend/optimizer/util/relnode.c
> @@ -648,7 +648,7 @@ void
> add_grouped_rel(PlannerInfo *root, RelOptInfo *rel, RelAggInfo *agg_info)
> {
> add_rel_info(root->grouped_rel_list, rel);
> - add_rel_info(root->agg_info_list, rel);
> + add_rel_info(root->agg_info_list, agg_info);
> }
>
Thanks! Yes, this is what I had to fix.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Attachment | Content-Type | Size |
---|---|---|
v14-0001-Introduce-RelInfoList-structure.patch | text/x-diff | 12.3 KB |
v14-0002-Introduce-make_join_rel_common-function.patch | text/x-diff | 3.0 KB |
v14-0003-Aggregate-push-down-basic-functionality.patch | text/x-diff | 109.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeevan Chalke | 2019-07-17 14:41:53 | Re: block-level incremental backup |
Previous Message | Tom Lane | 2019-07-17 14:16:18 | Re: POC: converting Lists into arrays |