| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: s_lock_test no longer works |
| Date: | 2024-01-24 20:05:12 |
| Message-ID: | 198542.1706126712@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2024-01-24 12:14:17 +0100, Alvaro Herrera wrote:
>> I do wonder if we want to keep this around, given that it's been more
>> than one year broken and nobody seems to have noticed, and the Meson
>> build does not support the test as a target.
> Perhaps we should just make the test built and run by default instead? OTOH,
> regress.c:test_spinlock() actually covers about as much as the standalone
> test...
If your spinlocks aren't working, it's unlikely you'll get as far as
being able to run test_spinlock(). I think the standalone test does
have some value; it's just that it's not needed very often these days.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-01-24 20:20:28 | Re: index prefetching |
| Previous Message | Robert Haas | 2024-01-24 19:59:44 | Re: Emit fewer vacuum records by reaping removable tuples during pruning |