| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing SIZE_MAX |
| Date: | 2017-09-01 16:49:28 |
| Message-ID: | 19847.1504284568@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Sep 1, 2017 at 12:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> [ warning: more than you really wanted to know ahead ]
> It might be worth the effort to clean all of this up, just because the
> next person who gets bitten by it may not be as smart as you are.
Yeah. I was just thinking that maybe the appropriate investment of
effort is to make [U]INT64CONST smarter, so that it results in a
properly-suffixed constant and doesn't need a cast. Then it'd be a
lot easier to make these other macros be #if-safe.
Or we could just recast the test in fe-exec.c to not use SIZE_MAX.
Checking whether "SIZEOF_SIZE_T == 4" would really have the same
effect, though it's uglier.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-09-01 16:53:28 | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Previous Message | Magnus Hagander | 2017-09-01 16:47:08 | Re: log_destination=file |