Re: patch: contrib/pgcrypto sanity

Marko Kreen <marko(at)l-t(dot)ee> writes:
> date: 2000/12/04 01:20:38; author: tgl; state: Exp; lines: +18 -18
> Eliminate some of the more blatant platform-dependencies ... it
> builds here now, anyway ...

> Which basically changes u_int*_t -> uint*_t, so now it does not
> compile neither under Debian 2.2 nor under NetBSD 1.5 which
> is platform independent all right.

Well, that's annoying. I guess those platforms are out of step with the
C99 standard, which specifies uint*_t not u_int*_t (cf. C99 7.4.1.1).
I agree with your solution of switching to Postgres-supplied typenames.

> Also it replaces $KAME$ with $Id$ which is Bad Thing. PostgreSQL Id
> should be added as a separate line so the file history could be seen.

I didn't know what $KAME$ was, and took it for some national-language
variant of $Id$ that our CVS server didn't know about. Who/what is
KAME anyway?

> * adds back KAME Id, because KAME is the master repository

Is that a good idea? If we are deliberately deviating from whatever
"master repository" this is, I'm not sure that we should continue to
label the code with their revision ID.

regards, tom lane