| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver |
| Date: | 2017-03-04 04:11:33 |
| Message-ID: | 19815.1488600693@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 3/3/17 19:16, Tom Lane wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> Use asynchronous connect API in libpqwalreceiver
>> Buildfarm member bowerbird has been failing in the pg_rewind test since
>> this patch went in. It looks like it's failing to complete connections
>> from the standby; which suggests that something platform-specific is
>> missing from this commit, but I dunno what.
> Hmm, I wonder how widely tested the async connection API is on Windows
> at all. I only see bowerbird and jacana running bin-check on Windows.
Yeah, I was wondering if this is just exposing a pre-existing bug.
However, the "normal" path operates by repeatedly invoking PQconnectPoll
(cf. connectDBComplete) so it's not immediately obvious how such a bug
would've escaped detection.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-04 04:43:34 | pgsql: Fix parsing of DROP SUBSCRIPTION ... DROP SLOT |
| Previous Message | Peter Eisentraut | 2017-03-04 02:46:20 | Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-03-04 04:37:50 | Re: [BUG FIX] Removing NamedLWLockTrancheArray |
| Previous Message | Peter Eisentraut | 2017-03-04 04:09:05 | Re: Automatic cleanup of oldest WAL segments with pg_receivexlog |