| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Christoph Berg <myon(at)debian(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Subject: | Re: Potential ABI breakage in upcoming minor releases |
| Date: | 2024-11-14 20:49:02 |
| Message-ID: | 1980993.1731617342@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Aleksander Alekseev <aleksander(at)timescale(dot)com> writes:
> The third case is the following:
> ```
> extern TSDLLEXPORT ResultRelInfo *
> ts_catalog_open_indexes(Relation heapRel)
> {
> ResultRelInfo *resultRelInfo;
> resultRelInfo = makeNode(ResultRelInfo);
> resultRelInfo->ri_RangeTableIndex = 0; /* dummy */
> resultRelInfo->ri_RelationDesc = heapRel;
> resultRelInfo->ri_TrigDesc = NULL; /* we don't fire triggers */
> ExecOpenIndices(resultRelInfo, false);
> return resultRelInfo;
> }
> ```
I'd call that a bug in timescale. It has no business assuming that
it can skip InitResultRelInfo.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Filip Janus | 2024-11-14 22:13:16 | Proposal: Adding compression of temporary files |
| Previous Message | Aleksander Alekseev | 2024-11-14 20:44:11 | Re: Potential ABI breakage in upcoming minor releases |