From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Rethink the wait event names for postgres_fdw, dblink and etc |
Date: | 2023-08-18 03:27:02 |
Message-ID: | 197bce267fa691a0ac62c86c4ab904c4@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Recently, the API to define custom wait events for extension is
supported.
* Change custom wait events to use dynamic shared hash tables(af720b4c5)
So, I'd like to rethink the wait event names for modules which use
"WAIT_EVENT_EXTENSION" wait events.
* postgres_fdw
* dblink
* pg_prewarm
* test_shm_mq
* worker_spi
I expect that no one will object to changing the names to appropriate
ones. But, we need to discuss that naming convention, the names
themselves,
document descriptions and so on.
I made the v1 patch
* CamelCase naming convention
* Add document descriptions for each module
I haven't added document descriptions for pg_prewarm and test modules.
The reason is that the wait event of autoprewarm is not shown on
pg_stat_activity. It's not an auxiliary-process and doesn't connect to
a database, so pgstat_bestart() isn't be called.
Feedback is always welcome and appreciated.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Make-to-use-custom-wait-events-for-modules.patch | text/x-diff | 13.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | shveta malik | 2023-08-18 03:49:10 | Re: Adding a LogicalRepWorker type field |
Previous Message | Amit Kapila | 2023-08-18 03:20:26 | Re: Adding a LogicalRepWorker type field |