| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | ldm(at)apartia(dot)ch, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: failed to compile a C++ SPI function |
| Date: | 2000-10-08 03:57:12 |
| Message-ID: | 19799.970977432@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I am willing to change it to typname. Any comments?
That's hardly the only change you will have to make to get the headers
to pass through a C++ compiler without complaint. How many existing
applications do you want to risk breaking?
ParamNo probably isn't a widely used node type, but there are four
structs with fields named 'typename' and one with a field named 'class'
just in parsenodes.h.
I think that before we start making changes with C++ cleanness as a
goal, we should try to get a precise idea of the extent of the changes
that would be needed, and then estimate how much user code might
reference the fields we'd need to rename.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2000-10-08 04:02:00 | Re: Re: [ANNOUNCE] Announce: Release of PyGreSQL version 3.0 |
| Previous Message | Marc G. Fournier | 2000-10-08 03:55:09 | Re: Re: [ANNOUNCE] Announce: Release of PyGreSQL version 3.0 |