Re: [PATCH] Make skipped sort explicit in EXPLAIN ANALYZE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Make skipped sort explicit in EXPLAIN ANALYZE
Date: 2012-05-25 13:49:18
Message-ID: 19766.1337953758@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Marti Raudsepp <marti(at)juffo(dot)org> writes:
> This is just a small clarity improvement. tuplesort_performsort()
> skips sorting entirely when the result set has 0 or 1 tuples, but
> EXPLAIN still says it's using "quicksort". The patch changes that to
> "skipped"

I'm not convinced this is an improvement; it's just one more value
to confuse people with. And any implementation of quicksort is likely
to have a fast exit path for 0 or 1 item, so I don't think the existing
display is incorrect either.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2012-05-25 14:03:49 Re: pg_stat_statements temporary file
Previous Message Tom Lane 2012-05-25 13:39:17 Re: proclock table corrupted