Re: pgsql: Straighten include order in guc-file.l

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Straighten include order in guc-file.l
Date: 2022-11-03 13:19:00
Message-ID: 1974929.1667481540@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> flaviventris fails on the pg_resetwal test with "initdb: error: invalid
> locale settings; check LANG and LC_* environment variables", and
> idiacanthus fails to start the server in another tap test. But if this
> commit were at fault, surely they would fail more spectacularly?

Given the shortage of other failures, I'd write these off as noise
... unless they reproduce in future runs. But even then, it's
very hard to blame it on this commit.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-11-03 14:47:40 pgsql: Add casts to simplehash.h to silence C++ warnings.
Previous Message John Naylor 2022-11-03 06:03:04 Re: pgsql: Straighten include order in guc-file.l