Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic
Date: 2023-10-14 23:45:21
Message-ID: 1974777.1697327121@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Noah Misch <noah(at)leadboat(dot)com> writes:
> ... This fix makes interval_ops simply omit the support function,
> like numeric_ops does. Back-pack to v13, where btequalimage() first
> appeared. In back branches, for the benefit of old catalog content,
> btequalimage() code will return false for type "interval". Going
> forward, back-branch initdb will include the catalog change.

Hmm, I'm not sure that that last is a good idea. The upshot of this
(because of the opr_sanity.out change) is that "make installcheck"
will fail against existing back-branch installations. That seems
more likely to cause problems/confusion than the alternative of just
depending on the code change.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2023-10-15 00:03:58 Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic
Previous Message Noah Misch 2023-10-14 23:35:41 pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic