Re: pgAgent: C++ Port - Patch Review

Hi,

> > 1.)
> >
> > it is system dependent. On my SUSE system pibpg-header to be
> > installed under the pgsql directory.
> >
> > Example: /usr/include/pgsql/libpq-fe.h
>
> As we discussed we should remove the pgsql/ prefix.
of course, i will correct it.

>
> > 2.)
> >
> > I changed tmpnam to mkdtemp.
> >
> > I hope thats is okay
>
> OK.
>
> > 3.)
> >
> > Can you tell me the name of the files. I will delete comments.
>
> connection.cpp
> job.cpp
> misc.cpp
> pgAgent.h
>
> Also check other files for commented codes.
Okay. I will check it.

> > 4.)
> >
> > its also my job?
>
> I think so because you have only implemented this feature so you are the
> best person to do it. :)
But please do not beat me for my english :)

> > 5.)
> >
> > I have corrected. In the default branch of the switch statement was
> > a return statement(Job.cpp Line: 325). Before that i have
> > a "delete steps," added
>
> That is fine. But what about return statement in Job.cpp:346 ?
Correct.
I hope i have all places of "return" corrected. :)