| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Joerg Sonnenberger <joerg(at)bec(dot)de>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, John Naylor <jcnaylor(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: reducing the footprint of ScanKeyword (was Re: Large writable variables) |
| Date: | 2019-01-09 22:21:01 |
| Message-ID: | 19717.1547072461@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> writes:
> On Wed, Jan 9, 2019 at 2:44 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> [patch to shrink oid index]
> It would help maintaining its newfound sveltness if we warned if a
> higher oid was assigned, as in the attached. I used 6200 as a soft
> limit, but that could be anything similiar.
I think the reason we have this issue is that people tend to use
high OIDs during development of a patch, so that their elbows won't
be joggled by unrelated changes. Then sometimes they forget to
renumber them down before committing. A warning like this would
lead to lots of noise during the development stage, which nobody
would thank us for. If we could find a way to notice this only
when we were about to commit, it'd be good .. but I don't have an
idea about a nice way to do that. (No, I don't want a commit hook
on gitmaster; that's warning too late, which is not better.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-09 22:33:41 | Re: reducing the footprint of ScanKeyword (was Re: Large writable variables) |
| Previous Message | John Naylor | 2019-01-09 22:09:48 | Re: reducing the footprint of ScanKeyword (was Re: Large writable variables) |