| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Chernow <ac(at)esilo(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] libpq type system 0.9a |
| Date: | 2008-04-09 14:25:29 |
| Message-ID: | 19672.1207751129@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Andrew Chernow <ac(at)esilo(dot)com> writes:
> There is no need to pass hookData to the hook function. libpqtypes already
> accesses PGconn and PGresult directly so it can just access the hookData member.
That's a habit you'd really be best advised to stop, if you're going to
be a separate library. Otherwise, any time we make an internal change
in the PGconn struct, it'll break your library --- and we have and will
feel free to do that without an external soname change.
What parts of PGconn/PGresult do you need to touch that aren't exposed
already?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shane Ambler | 2008-04-09 14:30:18 | Re: Concurrent psql API |
| Previous Message | Andrew Chernow | 2008-04-09 14:19:11 | Re: [PATCHES] libpq type system 0.9a |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shane Ambler | 2008-04-09 14:30:18 | Re: Concurrent psql API |
| Previous Message | Andrew Chernow | 2008-04-09 14:19:11 | Re: [PATCHES] libpq type system 0.9a |