| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade's exec_prog() coding improvement |
| Date: | 2012-08-24 14:08:58 |
| Message-ID: | 19651.1345817338@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> On 23.08.2012 23:07, Alvaro Herrera wrote:
>> One problem with this is that I get this warning:
>> /pgsql/source/HEAD/contrib/pg_upgrade/exec.c: In function s_exec_prog:
>> /pgsql/source/HEAD/contrib/pg_upgrade/exec.c:96:2: warning: function might be possible candidate for gnu_printf format attribute [-Wmissing-format-attribute]
>> /pgsql/source/HEAD/contrib/pg_upgrade/exec.c:96:2: warning: function might be possible candidate for gnu_printf format attribute [-Wmissing-format-attribute]
>>
>> I have no idea how to silence that. Ideas?
> You can do what the warning suggests, and tell the compiler that
> exec_prog takes printf-like arguments.
exec_prog already has such decoration, and Alvaro's patch doesn't remove
it. So the question is, exactly what the heck does that warning mean?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-08-24 14:10:07 | Re: 9.2RC1 wraps this Thursday ... |
| Previous Message | Amit Kapila | 2012-08-24 14:06:59 | Re: Recently noticed documentation issues |