Re: SRF memory mgmt patch (was [HACKERS] Concern about memory management with SRFs)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Subject: Re: SRF memory mgmt patch (was [HACKERS] Concern about memory management with SRFs)
Date: 2002-08-29 17:18:14
Message-ID: 19627.1030641494@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> Here's a patch to address Tom's SRF API memory management concerns, as
> discussed earlier today on HACKERS.

Patch committed.

It seemed to me that pgstattuple.c does not really want to be an SRF,
but only a function returning a single tuple. As such, it can provide
a fine example of using the funcapi.h tuple-building machinery *without*
the SRF machinery. I changed it accordingly, but am not able to update
README.pgstattuple.euc_jp; Tatsuo-san, would you handle that?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-08-29 18:32:31 Re: C vs. C++ contributions
Previous Message D'Arcy J.M. Cain 2002-08-29 17:17:35 Re: Proposed GUC Variable

Browse pgsql-patches by date

  From Date Subject
Next Message Manfred Koizar 2002-08-29 17:21:48 Re: Visibility regression test
Previous Message D'Arcy J.M. Cain 2002-08-29 17:17:35 Re: Proposed GUC Variable