Re: v7.2.4 bundled ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kevin Brown <kevin(at)sysexperts(dot)com>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: v7.2.4 bundled ...
Date: 2003-01-30 15:26:02
Message-ID: 19515.1043940362@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Kevin Brown <kevin(at)sysexperts(dot)com> writes:
> I'm attaching a patch for 7.2.4's parser/gram.y that fixes all of
> bison 1.75's complaints.

But parser/gram.y is not the only .y file in the distribution. To call
ourselves 1.75-safe, we'd have to go through this same exercise for
all of 'em:

$ find REL7_2 -name '*.y'
REL7_2/pgsql/contrib/cube/cubeparse.y
REL7_2/pgsql/contrib/seg/segparse.y
REL7_2/pgsql/src/backend/bootstrap/bootparse.y
REL7_2/pgsql/src/backend/parser/gram.y
REL7_2/pgsql/src/interfaces/ecpg/preproc/preproc.y
REL7_2/pgsql/src/pl/plpgsql/src/gram.y
$

And on top of that, 1.75 isn't the current bison release anymore; the
one that is current has changed the spelling of syntax error messages,
which means that the regression tests will fail (and perhaps clients
that are looking for syntax errors, too). We have agreed how to fix
this in HEAD, but not actually done it yet --- shall we put that
not-even-written-let-alone-tested code into 7.2.4 as well?

I think it's best to leave well enough alone. The tarball ships with
working bison output files anyway, so all of this really only matters
to people trying to build 7.2.* from a CVS pull.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message D'Arcy J.M. Cain 2003-01-30 15:43:32 PostgreSQL, NetBSD and NFS
Previous Message Tom Lane 2003-01-30 14:48:37 Re: Linux.conf.au 2003 Report

Browse pgsql-patches by date

  From Date Subject
Next Message Marc G. Fournier 2003-01-30 17:20:47 Re: v7.2.4 bundled ...
Previous Message Rod Taylor 2003-01-30 12:55:26 Re: v7.2.4 bundled ...