| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)hotmail(dot)com>, pgsql-patches(at)postgresql(dot)org, jonah(dot)harris(at)gmail(dot)com |
| Subject: | Re: scrollable cursor sup. for SPI |
| Date: | 2007-01-15 19:49:46 |
| Message-ID: | 19495.1168890586@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> BTW, how do people feel about the function names:
> SPI_cursor_open_with_options
> SPI_scroll_cursor_fetch
> SPI_scroll_cursor_move
I dislike the SPI_cursor_open_with_options API on the grounds that it
lets people break things (CURSOR_OPT_HOLD for instance isn't likely
to do anything good) and it doesn't actually provide any functionality
that wasn't there before (the existing code already sets OPT_SCROLL
if possible). I'd suggest losing that one entirely and just adding
the FetchDirection-as-substitute-for-"forward" entry points.
As for names, maybe
SPI_cursor_fetch_direction
SPI_cursor_move_direction
?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-01-15 20:31:29 | Re: [HACKERS] Autovacuum improvements |
| Previous Message | Neil Conway | 2007-01-15 18:48:03 | Re: scrollable cursor sup. for SPI |