Re: Re: pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: Re: pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol
Date: 2014-10-30 14:10:13
Message-ID: 19489.1414678213@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Wed, Oct 29, 2014 at 10:12:44PM +0000, Tom Lane wrote:
>> To fix, suppress the hint-flag updates if we are InTransactionBlock().

> Shouldn't this use IsInTransactionChain(), to catch the other ways ANALYZE can
> share a transaction with DDL?

Hm, I think you're right. Will fix, thanks.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2014-10-30 15:49:54 pgsql: "Pin", rather than "keep", dynamic shared memory mappings and se
Previous Message Noah Misch 2014-10-30 04:09:36 Re: pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol