Re: JIT compiling with LLVM v9.1

From: Pierre Ducroquet <pierre(dot)ducroquet(at)people-doc(dot)com>
To: Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: JIT compiling with LLVM v9.1
Date: 2018-02-05 10:39:06
Message-ID: 1948449.DvU0xjqrTG@pierred-pdoc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sunday, February 4, 2018 12:45:50 AM CET Andreas Karlsson wrote:
> On 02/02/2018 10:48 AM, Pierre Ducroquet wrote:
> > I have successfully built the JIT branch against LLVM 4.0.1 on Debian
> > testing. This is not enough for Debian stable (LLVM 3.9 is the latest
> > available there), but it's a first step.
> > I've split the patch in four files. The first three fix the build issues,
> > the last one fixes a runtime issue.
> > I think they are small enough to not be a burden for you in your
> > developments. But if you don't want to carry these ifdefs right now, I
> > maintain them in a branch on a personal git and rebase as frequently as I
> > can.
>
> I tested these patches and while the code built for me and passed the
> test suite on Debian testing I have a weird bug where the very first
> query fails to JIT while the rest work as they should. I think I need to
> dig into LLVM's codebase to see what it is, but can you reproduce this
> bug at your machine?
>
> Code to reproduce:
>
> SET jit_expressions = true;
> SET jit_above_cost = 0;
> SELECT 1;
> SELECT 1;
>
> Output:
>
> postgres=# SELECT 1;
> ERROR: failed to jit module
> postgres=# SELECT 1;
> ?column?
> ----------
> 1
> (1 row)
>
> Config:
>
> Version: You patches applied on top of
> 302b7a284d30fb0e00eb5f0163aa933d4d9bea10
> OS: Debian testing
> llvm/clang: 4.0.1-8
>
> Andreas

I have fixed the patches, I was wrong on 'guessing' the migration of the API
for one function.
I have rebuilt the whole patch set. It is still based on 302b7a284d and has
been tested with both LLVM 3.9 and 4.0 on Debian testing.

Thanks for your feedback !

Attachment Content-Type Size
0001-Add-support-for-LLVM4-in-llvmjit.c.patch text/x-patch 2.4 KB
0002-Add-LLVM4-support-in-llvmjit_error.cpp.patch text/x-patch 1.4 KB
0003-Add-LLVM4-support-in-llvmjit_inline.cpp.patch text/x-patch 3.1 KB
0004-Don-t-emit-bitcode-depending-on-an-LLVM-5-function.patch text/x-patch 849 bytes
0006-Fix-segfault-with-LLVM-3.9.patch text/x-patch 1.0 KB
0005-Fix-building-with-LLVM-3.9.patch text/x-patch 2.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2018-02-05 10:43:21 Re: non-bulk inserts and tuple routing
Previous Message Amit Khandekar 2018-02-05 09:59:27 Re: Query running for very long time (server hanged) with parallel append