Re: [HACKERS] A weird bit in pg_upgrade/exec.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: a(dot)akenteva(at)postgrespro(dot)ru
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] A weird bit in pg_upgrade/exec.c
Date: 2017-11-16 16:20:02
Message-ID: 19439.1510849202@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

a(dot)akenteva(at)postgrespro(dot)ru writes:
> I see this bug is now fixed in pg_upgrade/exec.c => check_bin_dir().

> There's another bit exactly like that in check_data_dir() though.

Oh, so there is ... and looking around, that seems to have been
copied-and-pasted out of check_cluster_versions(), without any
thought for the fact that those calls were thereby made redundant.

Fix pushed, thanks for noticing!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-11-16 16:21:11 Re: pgsql: Disable installcheck tests for test_session_hooks
Previous Message Justin Clift 2017-11-16 15:51:41 Re: Schedule for migration to pglister